@dansup @jippi @pixelfed

My Traefik stack trembles with anticipation…

@tim @pfefferle @dansup

Hate to be "that guy" again, but there's another edge case that breaks the Litespeed cache fix for the Activitypub WP plugin.

When Pixelfed fires off ActivityPubFetchService.get, it sends an Accept header of:

"application/activity+json, application/ld+json"

Although this is matched in the ActivtyPub plugin, it isn't matched in the Litespeed Cache fix. With the same effects as before.

I've amended the RewriteCond to match the plugin regex for now. That seems to work.

@tim @pfefferle @dansup

These are the reproduction steps I'm using:

* Latest WP with latest Litespeed and Activitypub plugins.
* Add Tim's initial fix to .htaccess, with [NC] for case-insensitive matching.
* Purge cache to be sure.
* curl --header "Accept: application/activity+json, application/ld+json" (WP post url)
* activitystream json should be returned
* curl --header "Accept: */* " (same url)
* Expected result is HTML, however the cached activitystream json is incorrectly returned.

@tim @pfefferle @dansup

functions.php, line 343:
if ( preg_match( '/(application\/(ld\+json|activity\+json|json))/i', $accept ) ) {

Saying that, Tim's fix may work in this case. My RewriteCond had ^ and $ in the RegEx.

@tim @pfefferle @dansup

Aye, I think when I first implemented your fix those checks were in place. RegEx is a law unto itself!

I've replaced the RewriteCond with what you have on the blog right now, and added the [NC] flag to cover the case issue.

That's both the edge cases resolved from my side.

Many thanks!

@tim @pfefferle

It's the Accept: header coming from a random third party, not the plugin.

My hosting doesn't log that header, but I'd guess that third party is sending an Accept with incorrect casing.

The .htaccess RewriteCond didn't pick it up, so didn't add the Cache-Control:vary suffix.

However, the ActivityPub plugin matched the header regardless of case and returned the activitystreams json as expected. Which may be correct behaviour in itself.

It is then returned for all Accept types

Still getting trouble combining the #activitypub and #litespeed cache plugins on my #wordpress site. I’ve implemented Tim Nolte‘s .htaccess changes to vary on Accept type, and that works when manually testing with a browser and Postman. But every now and then the Activitypub JSON gets cached and delivered to a regular browser.

Has there been a recent change to the accepted application types that the RewriteCond needs to pick up on? If so, which apps use this different type?

@pfefferle @tim

@pfefferle @tim Found the problem!

The ActivityPub plugin returns JSON regardless of the case of the Accept header. (So application/json and application/JSON will both work.)

However, Tim's RewriteCond is case sensitive, so only the correctly formatted application/json header will trigger the vary fix.

Slapping [NC] at the end of the RewriteCond does the job.

#activitypub #wordpress #litespeedcache

@pfefferle Some great suggestions already.

For me, the ability to fine tune how the Fediverse profile is presented would be great. I believe there’s some work on the roadmap to better define how the Header Image, Icon, Biography and other profile details are propogated. It would be good as well to be able to add validated links to the profile at the blog level.

There may be a capacity to do this in the separate webfinger and nodeinfo plugins, but those are too opaque for a non-technical admin.