Notices by Kevin (ikke@ipv6.social)

@lanodan @domi
The builders have the repositories locally, so they are not affected by the mirrors.

That also means we still have a copy of all packages.

@drewdevault according to https://tukaani.org/xz-backdoor/ this was already the case.

"Tarballs created by Jia Tan were signed by him. Any tarballs signed by me were created by me."

The test in this case created a directory structure with files and directories. It also removed read permissions of some of them.

It then calls tor_glob with a path, and expects the result to be null (!result), and that assertion was failing on the builders.

In gdb, I saw that result was an empty list instead of NULL. Looking at tor_glob, what was returned depended on the return code of glob(). In case of GLOB_NOMATCH, it returns an empty list, and in case of GLOB_ABORT, it returns NULL.

I tried to dive into the musl do_glob() function, it would take too much time to pinpoint the issue myself.

I decided to report it in the #musl irc channel and after providing full strace outputs of both the working and not-working case, @dalias identified the issue due to the order of returned entries being different.

Another case where running upstream tests catches bugs:

http://ix.io/4EpQ

This was a bug that only happened on the builders, not in CI or local dev environments. Decided to dive in to find out what caused the difference.

Thanks @dalias for confirming the issue and coming with a fix so quickly.

#AlpineLinux