Here’s the goalpost for technical basis to reject this PR. It must meet ALL of the requirements:
- It must introduce a bug that wasn’t already there
- It can’t be from data errors created by another endpoint
- The same complaint can’t be issued against any other endpoints already in the codebase, example: if the complaint is that you can inundate the scrobbles endpoint, then the same complaint can be made about the statuses endpoint, making this an invalid basis for rejection
- It must reproducible
I’m not setting this goalpost because I think it will be met, I’m setting it because I want to give those who aren’t technical a baseline for evaluation here. If ANY of these requirements aren’t met, we can conclude that it’s not about any technical issue. It’s about who made the PR.