Conversation

Notices

1. Embed this notice
   Rich Felker (dalias@hachyderm.io)'s status on Monday, 19-Aug-2024 02:31:27 JST Rich Felker

   Proposed patch to replace if(0) obfuscation with explicit gotos. 🤔

   Looks sufficiently non-invasive and like a significant improvement to readability.

   • Haelwenn /элвэн/ :triskell: likes this.
   • Embed this notice
     Rich Felker (dalias@hachyderm.io)'s status on Monday, 19-Aug-2024 02:31:25 JST Rich Felker

     in reply to

     • datarama

     @datarama No need to convince me. I don't have anything against gotos. I think the original code was just an exercise in "look, this can be done without gotos!" and highlighting how case statements are really labels not blocks.

     But it's a perpetual source of "musl printf is hideous and unreadable!" complaints that detract from what's otherwise (hey I might be biased but I think this is fair) the best printf implementation out there.

     Haelwenn /элвэн/ :triskell: likes this.
   • Embed this notice
     datarama (datarama@hachyderm.io)'s status on Monday, 19-Aug-2024 02:31:26 JST datarama

     in reply to

     @dalias I've used gotos much like this in lexers, and a few other state machines. When what you actually mean is "nonrecoverably transfer control to somewhere else", they're often the best you can do for readability in a langauge that doesn't have tail-call optimization.

   • Embed this notice
     Enno T. Boland (gottox@chaos.social)'s status on Monday, 19-Aug-2024 02:32:35 JST Enno T. Boland

     in reply to

     @dalias I never thought I would've said that, but please use gotos! :D

     Haelwenn /элвэн/ :triskell: likes this.
   • Embed this notice
     Rich Felker (dalias@hachyderm.io)'s status on Monday, 19-Aug-2024 02:53:10 JST Rich Felker

     in reply to

     • Enno T. Boland

     @Gottox switch statements are gotos anyway. 🙃

     Haelwenn /элвэн/ :triskell: likes this.
   • Embed this notice
     Enno T. Boland (gottox@chaos.social)'s status on Monday, 19-Aug-2024 02:53:12 JST Enno T. Boland

     in reply to

     @dalias It's a misconception that `goto`s must not be used. There are usecases - especially in C which lacks the 'defer' statement - where it's just needed to write non-awful code.