Embed Notice

HTML Code

<blockquote style="position: relative; padding-left: 55px;"><section><a href="https://hachyderm.io/users/dalias/statuses/112984178130897468">Rich Felker (dalias@hachyderm.io)'s status on Monday, 19-Aug-2024 02:31:27 JST</a><a href="https://hachyderm.io/@dalias" title="dalias@hachyderm.io"><img src="https://gnusocial.jp/avatar/40873-48-20221207231635.webp" width="48" height="48" alt="Rich Felker" style="position: absolute; left: 0; top: 0;">Rich Felker</a></section><article><p>Proposed patch to replace if(0) obfuscation with explicit gotos. 🤔</p><p>Looks sufficiently non-invasive and like a significant improvement to readability.</p></article><footer><a rel="bookmark" href="https://gnusocial.jp/conversation/3535836#notice-6943140">In conversation</a><time datetime="2024-08-19T02:31:27+09:00" title="Monday, 19-Aug-2024 02:31:27 JST">about 3 months ago</time> <span>from <span><a href="https://hachyderm.io/@dalias/112984178130897468" rel="external" title="Sent from hachyderm.io via ActivityPub">hachyderm.io</a></span></span><a href="https://hachyderm.io/@dalias/112984178130897468">permalink</a><h4>Attachments</h4><ol><li><label><a rel="external" href="https://gnusocial.jp/attachment/3056671">Patch text:diff --git a/src/stdio/vfprintf.c b/src/stdio/vfprintf.c
index 360d723a..3c450c3a 100644
--- a/src/stdio/vfprintf.c
+++ b/src/stdio/vfprintf.c
@@ -557,11 +557,11 @@ static int printf_core(FILE *f, const char *fmt, va_list *ap, union arg *nl_arg,
 		case 'x': case 'X':
 			a = fmt_x(arg.i, z, t&amp;32);
 			if (arg.i &amp;&amp; (fl &amp; ALT_FORM)) prefix+=(t&gt;&gt;4), pl=2;
-			if (0) {
+			goto ifmt_tail;
 		case 'o':
 			a = fmt_o(arg.i, z);
 			if ((fl&amp;ALT_FORM) &amp;&amp; p&lt;z-a+1) p=z-a+1;
-			} if (0) {
+			goto ifmt_tail;
 		case 'd': case 'i':
 			pl=1;
 			if (arg.i&gt;INTMAX_MAX) {
@@ -573,7 +573,7 @@ static int printf_core(FILE *f, const char *fmt, va_list *ap, union arg *nl_arg,
 			} else pl=0;
 		case 'u':
 			a = fmt_u(arg.i, z);
-			}
+		ifmt_tail:
 			if (xp &amp;&amp; p&lt;0) goto overflow;
 			if (xp) fl &amp;= ~ZERO_PAD;
 			if (!arg.i &amp;&amp; !p) {</a></label><br><a href="https://media.hachyderm.io/media_attachments/files/112/984/169/464/216/786/original/b226ff84d9a99712.png" rel="external">https://media.hachyderm.io/media_attachments/files/112/984/169/464/216/786/original/b226ff84d9a99712.png</a></li></ol></footer></blockquote>

Corresponding Notice

Embed this notice
Rich Felker (dalias@hachyderm.io)'s status on Monday, 19-Aug-2024 02:31:27 JST Rich Felker
Proposed patch to replace if(0) obfuscation with explicit gotos. 🤔
Looks sufficiently non-invasive and like a significant improvement to readability.
In conversationabout 3 months ago from hachyderm.iopermalink
Attachments
1. Patch text: diff --git a/src/stdio/vfprintf.c b/src/stdio/vfprintf.c index 360d723a..3c450c3a 100644 --- a/src/stdio/vfprintf.c +++ b/src/stdio/vfprintf.c @@ -557,11 +557,11 @@ static int printf_core(FILE *f, const char *fmt, va_list *ap, union arg *nl_arg, case 'x': case 'X': a = fmt_x(arg.i, z, t&32); if (arg.i && (fl & ALT_FORM)) prefix+=(t>>4), pl=2; - if (0) { + goto ifmt_tail; case 'o': a = fmt_o(arg.i, z); if ((fl&ALT_FORM) && p<z-a+1) p=z-a+1; - } if (0) { + goto ifmt_tail; case 'd': case 'i': pl=1; if (arg.i>INTMAX_MAX) { @@ -573,7 +573,7 @@ static int printf_core(FILE *f, const char *fmt, va_list *ap, union arg *nl_arg, } else pl=0; case 'u': a = fmt_u(arg.i, z); - } + ifmt_tail: if (xp && p<0) goto overflow; if (xp) fl &= ~ZERO_PAD; if (!arg.i && !p) {
  https://media.hachyderm.io/media_attachments/files/112/984/169/464/216/786/original/b226ff84d9a99712.png

Public

Embed Notice

HTML Code

Corresponding Notice