Conversation

Notices

1. Embed this notice
   Alex Gleason (alex@gleasonator.com)'s status on Monday, 20-Mar-2023 04:35:31 JST Alex Gleason

   Custom emoji reactions are now a thing lmao

   • Embed this notice
     Alex Gleason (alex@gleasonator.com)'s status on Monday, 20-Mar-2023 07:34:58 JST Alex Gleason

     in reply to

     • 

     @mint Normally we do that but there’s not a flag for everything. Anyway you saw a fix was merged already.

   • Embed this notice
      (mint@ryona.agency)'s status on Monday, 20-Mar-2023 07:35:00 JST 

     in reply to
     @alex I once again ask to check against features list in nodeinfo instead of hardcoding software version. Pleroma does `pleroma_custom_emoji_reactions`, ackoma `custom_emoji_reactions`.
     Screenshot_20230320_000120.png
   • Embed this notice
      (mint@ryona.agency)'s status on Monday, 20-Mar-2023 07:45:24 JST 

     in reply to

     • 

     @alex This should work. I would’ve made a proper MR, but gitlab throws a “checking your anus” page that infinitely redirects back to itself. Gott strafe Cloudflare.

     diff --git a/app/soapbox/utils/features.ts b/app/soapbox/utils/features.ts index e99d4c921..7e9436394 100644 --- a/app/soapbox/utils/features.ts +++ b/app/soapbox/utils/features.ts @@ -327,7 +327,10 @@ const getInstanceFeatures = (instance: Instance) => { /** * Ability to add non-standard reactions to a status. */ - customEmojiReacts: v.software === PLEROMA && gte(v.version, '2.5.50'), + customEmojiReacts: v.software === PLEROMA && any([ + features.includes('custom_emoji_reactions'), + features.includes('pleroma_custom_emoji_reactions') + ]), /** * Legacy DMs timeline where messages are displayed chronologically without groupings.
     Alex Gleason likes this.
   • Embed this notice
     Alex Gleason (alex@gleasonator.com)'s status on Monday, 20-Mar-2023 07:46:10 JST Alex Gleason

     in reply to

     • 

     @mint My bad I was skimming and thought you were talking about quotes. I’ll push the fix shortly with the other emoji code I’m editing

   • Embed this notice
      (mint@ryona.agency)'s status on Monday, 20-Mar-2023 07:46:11 JST 

     in reply to
     @alex Was it? At least in develop it still checks the version for customEmojiReacts capability.
   • Embed this notice
     Alex Gleason (alex@gleasonator.com)'s status on Monday, 20-Mar-2023 07:46:52 JST Alex Gleason

     in reply to

     • 

     @mint Sidenote: incredibly ghey that Akkoma removes the word “pleroma” from a compatibility string

   • Embed this notice
     flappypaddle (flappypaddle@hijacked.download)'s status on Monday, 20-Mar-2023 07:56:06 JST flappypaddle

     in reply to

     • 
     Add Mozilla and compatible. One of these days maybe we can run ocx files!
     Alex Gleason likes this.
   • Embed this notice
     Eris (eris@gleasonator.com)'s status on Monday, 20-Mar-2023 10:05:00 JST Eris

     in reply to
     @alex CAN’T USE. FIX PLS
   • Embed this notice
     Alex Gleason (alex@gleasonator.com)'s status on Monday, 20-Mar-2023 10:05:00 JST Alex Gleason

     in reply to

     • Eris

     @eris Refresh and try again

   • Embed this notice
     Alex Gleason (alex@gleasonator.com)'s status on Monday, 20-Mar-2023 10:09:01 JST Alex Gleason

     in reply to

     • Matty
     • Eris

     @matty @eris I just rewrote that entire section of the code. Though it still feels a bit lanky on mobile.

   • Embed this notice
     Matty (matty@nicecrew.digital)'s status on Monday, 20-Mar-2023 10:09:02 JST Matty

     in reply to

     • Eris
     We do need to make sure this react picker shows up in the center of the screen or something, but I can't find the class for it.
   • Embed this notice
     Alex Gleason (alex@gleasonator.com)'s status on Monday, 20-Mar-2023 10:11:27 JST Alex Gleason

     in reply to

     • Matty
     • Eris

     @matty @eris Not sure actually, seems fine now

   • Embed this notice
     Matty (matty@nicecrew.digital)'s status on Monday, 20-Mar-2023 10:11:28 JST Matty

     in reply to

     • Eris
     How so?
   • Embed this notice
     Matty (matty@nicecrew.digital)'s status on Monday, 20-Mar-2023 10:34:12 JST Matty

     in reply to

     • Eris
     Did you merge it already?
   • Embed this notice
     Alex Gleason (alex@gleasonator.com)'s status on Monday, 20-Mar-2023 10:34:12 JST Alex Gleason

     in reply to

     • Matty
     • Eris

     @matty @eris No it’s in an MR