Embed Notice
HTML Code
Corresponding Notice
- Embed this noticeI noticed two (hopefully minor) errors in the patches I sent earlier:
- I failed to untabify a couple of added lines in the second patch
- I failed to add the "contributed by" note to RELEASE_NOTES.md in the third patch
if you'd like me to send fixed versions thereof, whether over these minor issues or other ones, just let me know.
I'm open to discussing the design and details of any of them. the third is more of a working prototype than a proper implementation: the packing of so much functionality in a single function is probably unwise, maintenance-wise, but that was what worked, so that's what I shared to get a concrete depiction of the feature across, to get the conversation about it started. I hope the feature makes sense to you.
another nit: I found that the placement of the link to the message in the date is less than ideal. it might be better to place it next to the interaction buttons, where one would look for them after reading the whole message. I find myself occasionally having to page back up to get back to it, which I find less than ideal. the date made sense to me, for not using up more screen real state, and for being "intuitive" for a user coming from GNU social, but I'd be happy to change it. it probably makes sense to add an attribute to have the link opened in a separate tab or page, though; it makes little sense without that IMHO, but I didn't think of it before because I automatically go for the alternate button that will open it in another tab. again, I'd be happy to amend the patch, or post a follow up, just let me know
there's something exciting about using snac to share patches for snac, but I don't suppose it's the most convenient way to share them. if you'd rather get them by other means, I'll probably be happy to oblige; I'm probably going to set up a (plain) anon git server soon (I just haven't got 'round to doing so yet), and I could post only pull requests (in the original sense) here, pointing at branches to pull from in the git server