Notices where this attachment appears
-
Embed this notice
I noticed two (hopefully minor) errors in the patches I sent earlier:
- I failed to untabify a couple of added lines in the second patch
- I failed to add the "contributed by" note to RELEASE_NOTES.md in the third patch
if you'd like me to send fixed versions thereof, whether over these minor issues or other ones, just let me know.
I'm open to discussing the design and details of any of them. the third is more of a working prototype than a proper implementation: the packing of so much functionality in a single function is probably unwise, maintenance-wise, but that was what worked, so that's what I shared to get a concrete depiction of the feature across, to get the conversation about it started. I hope the feature makes sense to you.
another nit: I found that the placement of the link to the message in the date is less than ideal. it might be better to place it next to the interaction buttons, where one would look for them after reading the whole message. I find myself occasionally having to page back up to get back to it, which I find less than ideal. the date made sense to me, for not using up more screen real state, and for being "intuitive" for a user coming from GNU social, but I'd be happy to change it. it probably makes sense to add an attribute to have the link opened in a separate tab or page, though; it makes little sense without that IMHO, but I didn't think of it before because I automatically go for the alternate button that will open it in another tab. again, I'd be happy to amend the patch, or post a follow up, just let me know
there's something exciting about using snac to share patches for snac, but I don't suppose it's the most convenient way to share them. if you'd rather get them by other means, I'll probably be happy to oblige; I'm probably going to set up a (plain) anon git server soon (I just haven't got 'round to doing so yet), and I could post only pull requests (in the original sense) here, pointing at branches to pull from in the git server
-
Embed this notice
I submitted a Pull Request to update MacPorts' snac to 2.67 here:
https://github.com/macports/macports-ports/pull/27188
Two of three GitHub Actions Continuous Integration checks passed, which is a good sign; hopefully the others will pass without issues.
As usual, it's up to others with commit access to merge it!
Thanks again for your and others' continued improvements to snac! Specifically I noticed shout outs to nowster and Shamar in the RELEASE_NOTES.md and I seem to recall watching the discourse about the PID locking suggested and discussed rather collaboratively too!
(My apologies for the delay. The Makefile was slightly modified, which in turn broke the $files/Makefile.patch applied by MacPorts so I needed to rework that which took me a bit longer than usual given other work obligations I have had today.
Though not a concern for upstream, for MacPorts users I also noticed the following warning when running % port test:
"Warning: violation by /opt/local/man
Warning: snac violates the layout of the ports-filesystems!
Warning: Please fix or indicate this misbehavior (if it is intended), it will be an error in future releases!"
Though, it appears as if the man pages are where I think they should be for MacPorts? I have never seen that Warning before, so my guess is something about MacPorts intended prescriptive behavior has been changed but I am not exactly certain what the expected behavior is supposed to be now? I will look into it further, but hopefully it isn't a concern for users at the moment; just thought I would mention it for the sake of being thorough!
However, it's entirely possible I messed something up too; so if others with greater wisdom than I see that Warning and know what to do to correct it, or if they encounter any other issues with MacPorts' snac, others are more than welcome to submit Pull Requests with improvements! Or feel free to open up an issue on MacPorts Trac instance at https://trac.macports.org and I'll look into it.)
#snac #MacPorts #OpenSource #ActivityPub #Mastodon #NoDatabaseNeeded
#NoJavaScript #NoCookiesEither#NotMuchBullShit #snacAnnounces