@ryanc I had a legitimate use case for a swap partition on my NAS (though that was FreeBSD not Linux):
I installed it with a BIOS loader. After about ten years, I replaced the motherboard with one that had UEFI with no BIOS compat layer.
Having a swap partition meant I could boot a recovery image, shrink the swap partition and add a UEFI boot partition, without any risk to data I cared about.