Conversation

Notices

1. Embed this notice
   Paul Reinheimer (preinheimer@phpc.social)'s status on Wednesday, 15-Oct-2025 03:59:32 JST Paul Reinheimer

   Has anyone done research on the best place within a pull request to hide stuff?

   I'm thinking it's 80% through a good sized PR. At that point the reviewer is probably tired, but you're past the end where they might scroll to and perk back up.

   • Embed this notice
     Evan Prodromou 🇨🇦🇺🇸🇬🇷🇵🇸 (evan@cosocial.ca)'s status on Wednesday, 15-Oct-2025 03:59:31 JST Evan Prodromou 🇨🇦🇺🇸🇬🇷🇵🇸

     in reply to

     @preinheimer Big changes to package-lock.json, for NodeJS apps. Big changes get hidden in GitHub's PR interface. Also, I'll assume that any changes to package-lock.json were auto-generated. Also, I have no effin idea what the syntax of that file is.

   • Embed this notice
     Evan Prodromou 🇨🇦🇺🇸🇬🇷🇵🇸 (evan@cosocial.ca)'s status on Wednesday, 15-Oct-2025 07:16:12 JST Evan Prodromou 🇨🇦🇺🇸🇬🇷🇵🇸

     in reply to

     • Alerta! Alerta!

     @heiglandreas @preinheimer that's too big, though. Pushing that kind of change requires a lot of trust.

   • Embed this notice
     Alerta! Alerta! (heiglandreas@phpc.social)'s status on Wednesday, 15-Oct-2025 07:16:13 JST Alerta! Alerta!

     in reply to

     @preinheimer I'd say someqhere between file 235 and 317 of that 623 File PR with 12.437 changed lines....