dansup
Received an interesting bug report regarding the Pixelfed photo filters in the webUI.
The JS logic we employ can be abused for privacy reasons, and this user is using a browser that mitigates this, leading to long waits.
I know Pixelfed like the back of my hand, so that's why I asked which browser they are using, and of course, that is the real cause behind this issue!
dansup
@derfopps If you look at the actual code, you will see we simply create a canvas object and apply the filter to it.
While the canvas browser API can be abused in various ways, the only way to prevent that would be to eliminate the feature all together!
Philipp :geeko: :natenom:
@dansup Not sure that I like your stance on that. "The JS logic we employ can be abused for privacy reasons" pretty much means there is a security bug in your JS code, and if that's true, Vanadium is one of few browsers that mitigate it. WontFix pretty much sounds as if user safety isn't a concern for #Pixelfed then?
dansup
@jonasgeiler We are just creating a canvas object to apply the photo filters to!
Jonas Geiler
@dansup What kind of code are you using for filtering that it gets mitigated by the browser 🤔
dansup
@jonasgeiler I wasn't aware of that new API!
Will add that to my long todo list 😅
Jonas Geiler
@dansup Oh I see, an out-of-DOM canvas...
Maybe try out the new OffscreenCanvas API?
infinite love ⴳ
@dansup "don't worry"? 🤨
dansup
@trwnh yeah, I mean don't worry in the context of our usage!
We simply create a svg object and use that to apply the filter
You are reading too much into this, we're on the same team 🤠
dansup
@oblomov @trwnh that won't work, the canvas object is required to be able to apply the specific css filters for each filter
Oblomov
@dansup @trwnh if it's just an SVG object maybe you can do it without canvas? As in: create an actual SVG by its textual representation?
GNU social JP is a social network, courtesy of GNU social JP管理人. It runs on GNU social, version 2.0.2-dev, available under the GNU Affero General Public License.
All GNU social JP content and data are available under the Creative Commons Attribution 3.0 license.