Conversation

Notices

1. Embed this notice
   Tobias Bernard (tbernard@mastodon.social)'s status on Saturday, 10-Aug-2024 23:02:36 JST Tobias Bernard

   I've been trying to do more Circle reviews lately, and I've noticed that a lot of apps have very similar papercuts. Some of the classics are:

   - Not using the standard keyboard shortcuts (e.g. Ctrl+, for opening preferences) https://developer.gnome.org/hig/reference/keyboard.html
   - Missing a11y labels on buttons
   - Longer blocks of text not being screen reader accessible
   - Focus borders being weirdly shaped/glitchy

   Maybe having a little checklist for app devs to do themselves before applying could catch some of these?

   • Embed this notice
     Brage Fuglseth (bragefuglseth@fosstodon.org)'s status on Saturday, 10-Aug-2024 23:02:35 JST Brage Fuglseth

     in reply to

     @tbernard I've been thinking of writing a piece on applying to Circle, that would also include tips about looking through the entire review checklist before applying, being somewhat responsive to the reviewers during the process, etc. Some common papercuts could totally be included in that.

   • Embed this notice
     Tobias Bernard (tbernard@mastodon.social)'s status on Saturday, 10-Aug-2024 23:02:35 JST Tobias Bernard

     in reply to

     • Brage Fuglseth

     @bragefuglseth Do it, that's a great idea! Happy to look over drafts :)

     That said, I was thinking maybe we could also just include a few of these things in the actual issue template for applying?

   • Embed this notice
     Bø!rge (forteller@tutoteket.no)'s status on Saturday, 10-Aug-2024 23:02:35 JST Bø!rge

     in reply to

     • Brage Fuglseth

     @tbernard @bragefuglseth Yes, do it! Great stuff! Ofc there must be room for joining and improving over time, but if there are a11y stuff like this which is easy to fix but often forgotten/overlooked, it should be included in the requirements to get accepted

   • Embed this notice
     Tobias Bernard (tbernard@mastodon.social)'s status on Sunday, 11-Aug-2024 01:33:47 JST Tobias Bernard

     in reply to

     Update: Here's a quick draft for a pre-review checklist https://gitlab.gnome.org/Teams/Circle/-/merge_requests/116

   • Embed this notice
     Bø!rge (forteller@tutoteket.no)'s status on Sunday, 11-Aug-2024 01:33:47 JST Bø!rge

     in reply to

     @tbernard Great!

     Shouldn't "and the current window respectively" read "and the current window or tab respectively"?

     What about Ctrl (Shift) Tab for navigating tabs? Or is that automatic?