Conversation

Notices

1. Embed this notice
   fasterthanlime 🌌 (fasterthanlime@hachyderm.io)'s status on Sunday, 31-Mar-2024 03:44:58 JST fasterthanlime 🌌

   lmao, if I'm reading this right, a check in the xz CMakeLists.txt for whether a certain sandboxing mechanism is supported was disabled by... adding a period before the "void" keyword, making it fail.

   https://git.tukaani.org/?p=xz.git;a=blobdiff;f=CMakeLists.txt;h=0e4d464faba62a1270b40a0cb24c2c59e4ace409;hp=1f0191673b453ed789d915e35ee874a17818494a;hb=f9cf4c05edd14dedfe63833f8ccbe41b55823b00;hpb=af071ef7702debef4f1d324616a0137a5001c14c

   • Haelwenn /элвэн/ :triskell: repeated this.
   • Embed this notice
     scvalex (scvalex@mas.to)'s status on Sunday, 31-Mar-2024 03:44:56 JST scvalex

     in reply to

     @fasterthanlime And here's the commit that did it.

     Depending on how you review changes, it's not hard to imagine not spotting this.

     https://git.tukaani.org/?p=xz.git;a=commitdiff;h=328c52da8a2bbb81307644efdb58db2c422d9ba7

   • Embed this notice
     Haelwenn /элвэн/ :triskell: (lanodan@queer.hacktivis.me)'s status on Sunday, 31-Mar-2024 03:46:39 JST Haelwenn /элвэн/ :triskell:

     in reply to

     • scvalex

     @scvalex @fasterthanlime In fact even with syntax highlighting (which really ought to evolve to consider cases like theses but also = vs ==), I don't think this could have been caught.

   • Embed this notice
     aoanla (aoanla@hachyderm.io)'s status on Sunday, 31-Mar-2024 18:16:48 JST aoanla

     in reply to

     • piegames
     • Sebastian LaVine
     • scvalex

     @smlavine @piegames @scvalex @fasterthanlime the line between \#include <sys/prctl.h> and void my_sandbox(void) has a . on it (it's the only thing in the line)

     gidi likes this.
   • Embed this notice
     Sebastian LaVine (smlavine@fosstodon.org)'s status on Sunday, 31-Mar-2024 18:16:49 JST Sebastian LaVine

     in reply to

     • piegames
     • scvalex

     @piegames @scvalex @fasterthanlime I have been looking at this for a while too, can you point to the problem?

     gidi repeated this.
   • Embed this notice
     piegames (piegames@flausch.social)'s status on Sunday, 31-Mar-2024 18:16:50 JST piegames

     in reply to

     • scvalex

     @scvalex @fasterthanlime wow, this is evil. Even knowing what to look for, it took me several attempts to spot it. (Side note: I would likely have no difficulties spotting this with GitHub's diff rendering. Good UI matters.)