Conversation

Notices

1. Embed this notice
   ilja (ilja@ilja.space)'s status on Monday, 12-Sep-2022 20:11:50 JST ilja
   Last week I started working a it more ttd on admin-fe, but I'm honestly wondering how much sense it makes for what I'm doing.
   I'm basically writing a ton more code and spending time on the test than on the actual functionality. And the functionality isn't even that much. It's just hiding certain elements in specific cases, that's it...
   • Hélène likes this.
   • Embed this notice
     Hélène (helene@p.helene.moe)'s status on Monday, 12-Sep-2022 20:12:24 JST Hélène

     in reply to
     @ilja it's a struggle because admin-fe basically has no tests and is a mess; if you want, you don't have to implement it, just document what to do and i'll try doing that!
   • Embed this notice
     Hélène (helene@p.helene.moe)'s status on Monday, 12-Sep-2022 20:15:21 JST Hélène

     in reply to
     @ilja writing the feature; don't expect to have proper tests in there considering the state of admin-fe
     
     it's the software that gives timeout errors when downloading emoji packs after all, and the same that needs a cache flush when enabling db-based config for menus to show :cirnoHeh:
   • Embed this notice
     ilja (ilja@ilja.space)'s status on Monday, 12-Sep-2022 20:15:25 JST ilja

     in reply to

     • Hélène
     @helene
     
     > and I'll try doing that!
     You mean writing the tests?
     Hélène likes this.
   • Embed this notice
     ilja (ilja@ilja.space)'s status on Monday, 12-Sep-2022 20:18:56 JST ilja

     in reply to

     • Hélène
     @helene I think I'll just drop the tests for the other things that still need to happen. At least the "hide this element" ones. I also don't think these changes really improve admin-fe at all :/ They're needed for the changes in BE, but the whole thing just doesn't seem like it was really made for it and I'm just hacking it to make it work...
     Hélène likes this.
   • Embed this notice
     Hélène (helene@p.helene.moe)'s status on Monday, 12-Sep-2022 20:19:48 JST Hélène

     in reply to
     @ilja if we really want something like adminfe then honestly it should probably be rewritten, most likely in Phoenix Liveview and in BE at this point
   • Embed this notice
     ilja (ilja@ilja.space)'s status on Monday, 12-Sep-2022 20:24:24 JST ilja

     in reply to

     • Hélène
     @helene For what needs to happen, https://git.pleroma.social/pleroma/admin-fe/-/merge_requests/209
     
     When a logged-in user isn't privileged, they shouldn't see whatever buttons or drop-downs allow them actions they aren't privileged too. The issue lists what still needs to be done for those.
     Then there's also the fact a bunch of calls are being made, but a lot can return a 403, so we need a way to handle that.
     
     The rest of the hiding, I can do since I'm already working on it. The calls is something I still have to figure out.
     Hélène likes this.
   • Embed this notice
     ilja (ilja@ilja.space)'s status on Monday, 12-Sep-2022 20:24:33 JST ilja

     in reply to

     • Hélène
     @helene Not sure if it has to be BE, but yeah, I had the same feeling when first poking at it :/ There's probably stuff in there that can be reused, but there's stuff in there that don't even look like it's being used. It also seems like it was written to go in a certain direction, but that direction is different of where we're going, so it's like going against the tide with that...
     Hélène likes this.
   • Embed this notice
     Hélène (helene@p.helene.moe)'s status on Monday, 12-Sep-2022 20:31:38 JST Hélène

     in reply to
     @ilja to me, having it in BE would be best especially if we want to get rid of FE bundles, and LiveView does allow us to basically not have to deal with the JavaScript ecosystem by writing everything in Elixir and on the server, which I feel is perfect when wanting to easily extend things and make good admin tools as the features grow
     It doesn't matter for it to be client side, it's all a panel for controlling the backend, so LiveView really would make sense
   • Embed this notice
     ilja (ilja@ilja.space)'s status on Monday, 12-Sep-2022 20:59:16 JST ilja

     in reply to

     • Hélène
     @helene
     
     > by writing everything in Elixir
     I'm sold :D
     
     LiveView seems interesting ? We probably still want things to be accessible via API (idk why, but somehow I think that's important), but having a build in FE doesn't exclude that. Having something that still allows to easily extend things seems good to me, and it would also allow us to fix the issue of having way too technical language and structure in the admin parts.
     Hélène likes this.
   • Embed this notice
     Hélène (helene@p.helene.moe)'s status on Monday, 12-Sep-2022 21:05:22 JST Hélène

     in reply to

     • i seethe and
     @cope @ilja Live Dashboard would be particularly great to have to also look at OBAN jobs this way, honestly, so yeah
   • Embed this notice
     i seethe and (cope@eeeeeeeee.eu)'s status on Monday, 12-Sep-2022 21:05:24 JST i seethe and

     in reply to

     • Hélène
     @helene phoenix already has a dashboard that was enable in develop some time ago, integrating it with pleroma features is another question
     https://github.com/phoenixframework/phoenix_live_dashboard
     Hélène likes this.
   • Embed this notice
     Hélène (helene@p.helene.moe)'s status on Monday, 12-Sep-2022 21:08:05 JST Hélène

     in reply to

     • i seethe and
     @cope @ilja i thought it was added but i indeed completely missed this
   • Embed this notice
     i seethe and (cope@eeeeeeeee.eu)'s status on Monday, 12-Sep-2022 21:08:06 JST i seethe and

     in reply to

     • Hélène
     • i seethe and
     @cope @ilja so look at it
     * Added Phoenix LiveDashboard at /phoenix/live_dashboard
     Hélène likes this.
   • Embed this notice
     Sean King (seanking@freespeechextremist.com)'s status on Thursday, 15-Sep-2022 04:15:57 JST Sean King

     in reply to

     • Hélène
     @ilja @helene Literally sold on doing this. I experimented with doing that for my Fuck Gab! project. And it actually is pretty promising as a technology.
     Hélène likes this.