Conversation

Notices

1. Embed this notice
   Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 15:27:01 JST Matthias Pfefferle

   We just released a major rewrite of the #Webmention plugin for #WordPress (v5.0) I hope you do not find too many bugs ? thanks a lot @ David Shanske for his help and for always pushing me to finish this release ?

   https://wordpress.org/plugins/webmention/

   • Embed this notice
     Terence Eden (edent@mastodon.social)'s status on Wednesday, 05-Apr-2023 15:37:06 JST Terence Eden

     in reply to

     @pfefferle
     I've updated! Just waiting for some comments now ?

   • Embed this notice
     Terence Eden (edent@mastodon.social)'s status on Wednesday, 05-Apr-2023 15:53:56 JST Terence Eden

     in reply to

     @pfefferle
     It seems to have turned any existing mentions into a sort of facepile.
     Is there any way of getting them back into the comments?
     https://shkspr.mobi/blog/2023/03/zero-interfaces/
     (I can raise on GitHub if that's easier?)

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 15:53:56 JST Matthias Pfefferle

     in reply to

     • Terence Eden

     @Edent good catch! A GitHub issue would be perfect! We missed porting that feature from the semantic linkbacks plugin!

   • Embed this notice
     Terence Eden (edent@mastodon.social)'s status on Wednesday, 05-Apr-2023 15:57:39 JST Terence Eden

     in reply to

     @pfefferle Ummm... It also seems to have deleted all my comments!
     They're in the DB, but not showing on any post.
     Investigating now.

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 15:58:55 JST Matthias Pfefferle

     in reply to

     • Terence Eden

     @Edent ?

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 16:02:09 JST Matthias Pfefferle

     in reply to

     • Terence Eden

     @Edent just re-checked on my site and I can not see any issues yet. Maybe caching?

   • Embed this notice
     Terence Eden (edent@mastodon.social)'s status on Wednesday, 05-Apr-2023 16:08:51 JST Terence Eden

     in reply to

     @pfefferle No, it appears something you changed is messing with my comment walker. I'll do some digging.

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 16:12:59 JST Matthias Pfefferle

     in reply to

     • Terence Eden

     @Edent oh ?

   • Embed this notice
     Terence Eden (edent@mastodon.social)'s status on Wednesday, 05-Apr-2023 16:24:28 JST Terence Eden

     in reply to

     @pfefferle My comment code was calling `Linkbacks_Handler::get_canonical_url( $comment );`

     Which I guess you've now removed?

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 16:40:14 JST Matthias Pfefferle

     in reply to

     • Terence Eden

     @Edent yes!

   • Embed this notice
     Terence Eden (edent@mastodon.social)'s status on Wednesday, 05-Apr-2023 16:56:55 JST Terence Eden

     in reply to

     @pfefferle and now I need to check the comment meta for "protocol" right?
     It would be really nice if these changes were documented somewhere.

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 17:07:02 JST Matthias Pfefferle

     in reply to

     • Terence Eden

     @Edent no problem! I totally understand that.

   • Embed this notice
     Terence Eden (edent@mastodon.social)'s status on Wednesday, 05-Apr-2023 17:07:03 JST Terence Eden

     in reply to

     @pfefferle sorry for being grumpy.
     It is a great and useful plugin. I just wasn't expecting so many breaking changes first thing in the morning.

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 17:08:33 JST Matthias Pfefferle

     in reply to

     • Terence Eden

     @Edent the protocol has the information that it is a Webmention comment (ActivityPub sets activitypub as protocol) if you search for the type (like, share, …) you have to check „comment_type“

   • Embed this notice
     Terence Eden (edent@mastodon.social)'s status on Wednesday, 05-Apr-2023 17:10:13 JST Terence Eden

     in reply to

     @pfefferle got it!
     I'll send a PR soon for disabling specific types of comments (I get lots of reposts that I don't want to moderate, for example).

   • Embed this notice
     Matt 🔶 (LordMatt) (lordmatt@mastodon.social)'s status on Wednesday, 05-Apr-2023 18:45:22 JST Matt 🔶 (LordMatt)

     in reply to

     @pfefferle That would explain why the face piles on openmentions.com looked odd today.

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 18:54:14 JST Matthias Pfefferle

     in reply to

     • Matt 🔶 (LordMatt)

     @lordmatt oh no, do they? Do you have a link for me?

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Wednesday, 05-Apr-2023 19:02:05 JST Matthias Pfefferle

     in reply to

     • Terence Eden
     • Matt 🔶 (LordMatt)

     @lordmatt @Edent I am so sorry that you had/have issues, but it was a really big change and we had to release it, otherwise we would stick to the 4.x forever. So we thought release with some missing features and fix bugs/implement missing things asap. So please please do report everything you find!!! And sorry again. It should now be a good foundation to build on, without the requirement of other plugins.

   • Embed this notice
     Terence Eden (edent@mastodon.social)'s status on Wednesday, 05-Apr-2023 21:37:53 JST Terence Eden

     in reply to

     • Matt 🔶 (LordMatt)

     @pfefferle @lordmatt it's OK. Forced me to redesign some of my files which had lazy assumptions ?

   • Embed this notice
     Matt 🔶 (LordMatt) (lordmatt@mastodon.social)'s status on Thursday, 06-Apr-2023 04:35:34 JST Matt 🔶 (LordMatt)

     in reply to

     @pfefferle I can turn them back on. And... now they work fine. I'll call that a win.

     Here's the site if you are feeling nosey: https://openmentions.com