Conversation

Notices

1. Embed this notice
   Ross McKay (webaware@fosstodon.org)'s status on Friday, 17-Mar-2023 20:58:59 JST Ross McKay

   • Matthias Pfefferle
   • frank goossens 🇧🇪🇪🇺
   • Javier Casares

   @futtta @pfefferle @javiercasares

   How about: add header Vary: Accept

   Also define DONOTCACHE for PHP caching plugins that won't support varying cached content.

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Friday, 17-Mar-2023 19:39:00 JST Matthias Pfefferle

     in reply to

     • frank goossens 🇧🇪🇪🇺
     • Javier Casares

     @webaware @javiercasares @futtta the problem here is, that multiple headers are valid/possible by the spec: https://www.w3.org/TR/activitypub/#retrieving-objects

     What about to check for HTML accept header: something like do only cache if ther is `text/html` in the accept header? Cachify uses something similar: https://github.com/pluginkollektiv/cachify/pull/273/files

   • Embed this notice
     Ross McKay (webaware@fosstodon.org)'s status on Friday, 17-Mar-2023 19:39:04 JST Ross McKay

     in reply to

     • Matthias Pfefferle
     • frank goossens 🇧🇪🇪🇺
     • Javier Casares

     @javiercasares @futtta @pfefferle I reckon setting that Vary header will do the trick, for nginx at minimum and possibly some others.

   • Embed this notice
     Javier Casares (javiercasares@wpmastodon.es)'s status on Friday, 17-Mar-2023 19:39:07 JST Javier Casares

     in reply to

     • Matthias Pfefferle
     • frank goossens 🇧🇪🇪🇺

     @webaware @futtta I'll check with @pfefferle and see what we can do.

   • Embed this notice
     Ross McKay (webaware@fosstodon.org)'s status on Friday, 17-Mar-2023 19:39:08 JST Ross McKay

     in reply to

     • frank goossens 🇧🇪🇪🇺
     • Javier Casares

     @javiercasares @futtta

     Also note that the ActivityPub plugin doesn't look for only that one exact header, it looks for four of them:

     https://github.com/pfefferle/wordpress-activitypub/blob/master/includes/class-activitypub.php#L78-L81

   • Embed this notice
     Ross McKay (webaware@fosstodon.org)'s status on Friday, 17-Mar-2023 19:39:09 JST Ross McKay

     in reply to

     • Ryan McCue
     • frank goossens 🇧🇪🇪🇺
     • Javier Casares

     @javiercasares @futtta

     No so fast; that's not what I said in my post. I said that if you *wanted* to break cache for (that specific) Accept header, that's how you'd do it.

     But please read the thread from this post and below, where @rmccue argues that we *should* be caching JSON requests, and when.

     https://aus.social/@rmccue/110020902246277742

     Also note that caching some JSON requests are highly desirable, like oembed requests for example.

     https://snippets.webaware.com.au/snippets/caching-oembed-with-nginx/

   • Embed this notice
     Ross McKay (webaware@fosstodon.org)'s status on Friday, 17-Mar-2023 19:39:21 JST Ross McKay

     in reply to

     • frank goossens 🇧🇪🇪🇺

     @futtta

     If your (host is) using typical nginx config like this one on WP docs:

     https://wordpress.org/documentation/article/nginx/#nginx-fastcgi_cache

     Then you should be able to break caching with this:

     if ($http_accept = "application/json") {
     set $no_cache 1;
     }

     But nginx will cache different content based on the Accept header if you tell it to, e.g. as long as #WordPress #ActivityPub sends this with its responses, cache will differ by Accept header:

     header('Vary: Accept');

     https://nginx.org/en/docs/http/ngx_http_fastcgi_module.html#fastcgi_cache_valid

   • Embed this notice
     Javier Casares (javiercasares@wpmastodon.es)'s status on Friday, 17-Mar-2023 19:39:21 JST Javier Casares

     in reply to

     • frank goossens 🇧🇪🇪🇺

     @webaware @futtta that goes to Docs
     https://github.com/WordPress/Advanced-administration-handbook/issues/189

   • Embed this notice
     frank goossens 🇧🇪🇪🇺 (futtta@mastodon.social)'s status on Friday, 17-Mar-2023 19:39:22 JST frank goossens 🇧🇪🇪🇺

     #activitypub #wordpress #nginx does anyone have nginx example config to avoid activitypub requests (accept:application/json) being cached by nginx? I'm trying to "educate" my hosting company ;-)

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Friday, 17-Mar-2023 19:51:23 JST Matthias Pfefferle

     • frank goossens 🇧🇪🇪🇺
     • Javier Casares

     @futtta @webaware @javiercasares sure, but I thought as a quick fix :)

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Friday, 17-Mar-2023 20:58:58 JST Matthias Pfefferle

     in reply to

     • frank goossens 🇧🇪🇪🇺
     • Javier Casares

     @webaware @futtta @javiercasares But then caching would be unnecessary, because ActivityPub needs content negotiation for posts, pages, other post types and author pages. and then there is not much left to cache :)

   • Embed this notice
     Matthias Pfefferle (pfefferle@mastodon.social)'s status on Friday, 17-Mar-2023 21:39:38 JST Matthias Pfefferle

     in reply to

     • Donncha Ó Caoimh
     • frank goossens 🇧🇪🇪🇺
     • Javier Casares

     @webaware @futtta @javiercasares Btw. @donncha also added Accept header support to "WP Super Cache" https://github.com/Automattic/jetpack/pull/29456/files