Embed Notice
HTML Code
Corresponding Notice
- Embed this notice:hacker_f::hacker_s::hacker_e:
:revolvertan: https://git.freespeechextremist.com/gitweb/?p=fse;a=commitdiff;h=4dc8e97715a0b9d7043fd776904193bb565e937a :ocelot:
Also I didn't wanna force-push again (I AM EDITING CODE IN PRODUCTION) so the documentation is in this commit: https://git.freespeechextremist.com/gitweb/?p=fse;a=commitdiff;h=7e1fc8031a548e829b07b61980120deff3239d21
Copyright assigned in the file to the Pleroma project; I think that's all they need to eventually incorporate it if they want to after it's useful to people besides me. I'd do a PR but I think they wouldn't want it without tests and I don't want to write tests (I don't want to write *any* more Elixir if I can avoid it, but I always think I'm no longer writing more Elixir and I somehow end up writing more Elixir; still better than having to touch Mastodon) plus no one actually has access to Revolver besides me so it is not super useful. The commit cherry-picks cleanly, but is not going to be super useful to anyone but me at present, I think. The only practical reasons to push this are for anyone curious how FSE currently handles uploads, plus AGPLv3 compliance.
Anyway, if anyone wants to read it, I have essentially no confidence in my ability to write Elixir. I have written a lot of bad Elixir for git-'er-done purposes but have not written a lot of "good" Elixir and this is an attempt at writing "good" Elixir and thus there are a lot of reasons that "good" is in quotes. There is some stuff that is unclear in the code, there are comments near those bits.
Also check the URL on the attachments: they're going straight there by means of the code linked to above. So the stupid 301-then-Revolver-does-a-reverse-media-proxy hack is over! (Except I have to keep it running that way to handle older posts, avatars, emchajos.) There are a couple of infelicities in the Revolver network code, but once those are fixed, uploads should get faster; at present, downloading is faster and uploading is faster than it *was* but some issues with my local net connection have made uploading slower than I had hoped it'd be (and also fucked up my ability to debug this shit for about an hour). But after that's done, it should be using the regular block propagation and things should be working great.
So, anyway, if you're on FSE and the uploads are acting weird or not acting weird enough or something, probably me know.
wewanttheairwaves.gif
Radical_Dreamers_ReveD'Ordinateur_OC_ReMix.mp3