Embed Notice
HTML Code
Corresponding Notice
- Embed this notice
Phantasm (phnt@fluffytail.org)'s status on Thursday, 30-Jan-2025 08:07:53 JST Phantasm
@dcc @nyanide @sysrq @ins0mniak @mr64bit Yeah, that's very likely a bug. It threw it's hands up before dereferencing NULL. That it compiled doesn't mean it's _correct_.
Just by looking at the code very quickly, I think it improperly handles the case where it failed to get the resolve the sigs. It initializes it to None, tries to match some sig with a regex in a for loop and when every single one fails, it still is None. Which would later cause the crash when it tries to unwrap NULL.
https://github.com/iv-org/inv_sig_helper/blob/master/src/player.rs#L77