GNU social JP
  • FAQ
  • Login
GNU social JPは日本のGNU socialサーバーです。
Usage/ToS/admin/test/Pleroma FE
  • Public

    • Public
    • Network
    • Groups
    • Featured
    • Popular
    • People

Embed Notice

HTML Code

Corresponding Notice

  1. Embed this notice
    Jeff Grigg (jeffgrigg@mastodon.social)'s status on Thursday, 21-Nov-2024 00:03:56 JSTJeff GriggJeff Grigg
    in reply to
    • DeepBlue V7.X

    @deepbluev7 @charliermarsh

    If a code review were being done as a *discussion between peers*, then it would be far more appropriate to say, "Hmmm… I was thinking I would have done it this other way. But are there advantages to this way?" And that opens up a discussion. A text comment, marked as a required "todo," blocking merge, is a challenge, not a discussion.

    During discussion, the reviewer might agree that what the submitter did was the best choice.

    In conversationabout 6 months ago from mastodon.socialpermalink
  • Help
  • About
  • FAQ
  • TOS
  • Privacy
  • Source
  • Version
  • Contact

GNU social JP is a social network, courtesy of GNU social JP管理人. It runs on GNU social, version 2.0.2-dev, available under the GNU Affero General Public License.

Creative Commons Attribution 3.0 All GNU social JP content and data are available under the Creative Commons Attribution 3.0 license.