Embed Notice

HTML Code

<blockquote style="position: relative; padding-left: 55px;"><section><a href="https://mk.absturztau.be/notes/9zx2v8b362qr000o">niconiconi (niconiconi@mk.absturztau.be)'s status on Tuesday, 29-Oct-2024 06:14:31 JST</a><a href="https://mk.absturztau.be/@niconiconi" title="niconiconi@mk.absturztau.be"><img src="https://gnusocial.jp/theme/gnusocialjp/default-avatar-stream.png" width="48" height="48" alt="niconiconi" style="position: absolute; left: 0; top: 0;">niconiconi</a><div><a href="https://mk.absturztau.be/notes/9zwxibyuidx900mb" rel="in-reply-to">in reply to</a></div></section><article><p>Far from that simple! It didn't work because libopensmtpd is buggy. osmtpd_link_auth() should split the string "status|user", but the author thought it was "user|status", and it becomes a comparison between a username and pass/fail. :woozy_baa:</p></article><footer><a rel="bookmark" href="https://gnusocial.jp/conversation/3894878#notice-7614932">In conversation</a><time datetime="2024-10-29T06:14:31+09:00" title="Tuesday, 29-Oct-2024 06:14:31 JST">about a month ago</time> <span>from <span><a href="https://mk.absturztau.be/notes/9zx2v8b362qr000o" rel="external" title="Sent from mk.absturztau.be via ActivityPub">mk.absturztau.be</a></span></span><a href="https://mk.absturztau.be/notes/9zx2v8b362qr000o">permalink</a><h4>Attachments</h4><ol><li><label><a rel="external" href="https://gnusocial.jp/attachment/3367781">diff --git a/opensmtpd.c b/opensmtpd.c
index 4d551f0..f0bd4ae 100644
--- a/opensmtpd.c
+++ b/opensmtpd.c
@@ -1428,16 +1428,17 @@ osmtpd_link_tls(struct osmtpd_callback *cb, struct osmtpd_ctx *ctx, static void
 osmtpd_link_auth(struct osmtpd_callback *cb, struct osmtpd_ctx *ctx,
-    char *username, char *linedup)
+    char *status, char *linedup)
 {
        void (*f)(struct osmtpd_ctx *, const char *, enum osmtpd_auth_status);
-       char *status;
+       char *username;
        enum osmtpd_auth_status s;-       if ((status = strrchr(username, '|')) == NULL)
+       if ((username = strrchr(status, '|')) == NULL)
                osmtpd_errx(1, "Invalid auth received: %s", linedup);
-       status[0] = '\0';
-       status++;
+       username[0] = '\0';
+       username++;
+
        if (strcmp(status, "pass") == 0)
                s = OSMTPD_AUTH_PASS;
        else if (strcmp(status, "fail") == 0)</a></label><br><a href="https://misskey-taube.s3.eu-central-1.wasabisys.com/files/b1ab17bd-704d-46cd-a0ac-264aaef1b1b9.webp" rel="external">https://misskey-taube.s3.eu-central-1.wasabisys.com/files/b1ab17bd-704d-46cd-a0ac-264aaef1b1b9.webp</a></li></ol></footer></blockquote>

Corresponding Notice

Embed this notice
niconiconi (niconiconi@mk.absturztau.be)'s status on Tuesday, 29-Oct-2024 06:14:31 JST niconiconi
in reply to
Far from that simple! It didn't work because libopensmtpd is buggy. osmtpd_link_auth() should split the string "status|user", but the author thought it was "user|status", and it becomes a comparison between a username and pass/fail. :woozy_baa:
In conversationabout a month ago from mk.absturztau.bepermalink
Attachments
1. diff --git a/opensmtpd.c b/opensmtpd.c index 4d551f0..f0bd4ae 100644 --- a/opensmtpd.c +++ b/opensmtpd.c @@ -1428,16 +1428,17 @@ osmtpd_link_tls(struct osmtpd_callback *cb, struct osmtpd_ctx *ctx, static void osmtpd_link_auth(struct osmtpd_callback *cb, struct osmtpd_ctx *ctx, - char *username, char *linedup) + char *status, char *linedup) { void (*f)(struct osmtpd_ctx *, const char *, enum osmtpd_auth_status); - char *status; + char *username; enum osmtpd_auth_status s; - if ((status = strrchr(username, '|')) == NULL) + if ((username = strrchr(status, '|')) == NULL) osmtpd_errx(1, "Invalid auth received: %s", linedup); - status[0] = '\0'; - status++; + username[0] = '\0'; + username++; + if (strcmp(status, "pass") == 0) s = OSMTPD_AUTH_PASS; else if (strcmp(status, "fail") == 0)
  https://misskey-taube.s3.eu-central-1.wasabisys.com/files/b1ab17bd-704d-46cd-a0ac-264aaef1b1b9.webp

Public

Embed Notice

HTML Code

Corresponding Notice