ended up finding the solution

for loop in shiftletter did not account for strlen just returning length and not last index

l == i - 1

and i never accounted for capital letters so i made a copy of if with the alphabet replaced with a capped alphabet