jwz
XScreenSaver ffmpeg version skew.
Dear Lazyweb,
One of you could save me a whole lot of swearing if you would send me a patch that makes XScreenSaver 6.09 configured "--with-record-animation" compile without warning when linked against the ffmpeg 7.1 libraries rather than 4.x. (sample_fmts, supported_samplerates, ch_layouts are now deprecated and if there's a porting guide, I have not found it.)
Future generations thank you in advance.
https://jwz.org/b/yklt
Peter Krefting
@jwz @jwz I see you have a taker already, but if not I would be happy to have a look. Been through a couple of those library upgrades at $DAYJOB.
Aidan
Peter Krefting
@allsumnull @jwz I'm not promising anything. But I will have a look.
jwz
@nafmo I have a taker but notably not a patch!
Peter Krefting
@jwz The only compile error I get is for the missing include <libavcodec/avcodec.h> in hacks/ffmpeg-out.c ; making av_stream::codec const also removes a warning.
Everything builds, I'll have to hunt for warnings later; it's midnight around here now.
Peter Krefting
@jwz Indeed. I just need to get past the hard errors before fixing the warnings. My setup is quite obviously different from yours (considering some opinions you have expressed about the operating system I am using, I expect you are not using it (no, it's not RedmondOS)). 🙂
jwz
@nafmo Is is the obsolescence warnings I specifically care about.
Peter Krefting
@jwz Having said that, the only warning I get is about guess_channel_layout(), so I might be overlooking something.
Peter Krefting
@shiz Your solution looks correct. I didn't even get to the compiler warnings.
I did have to apply this patch to get the build working, due to me having set up Perl to default to Unicode mode:
https://e.pcloud.link/publink/show?code=XZFkMdZf77qLiQHiaQEU9Olf6ILmj1sxOqy
Shiz
@nafmo I would never want to take the joy of ffmpeg porting work from someone, so I'll just quietly note that I posted my patches further down-thread too :)
Peter Krefting
@shiz @jwz Those fixes look good, and are a lot more thorough than anything I would have produced... 🙂
Great jon (and a very useful case study on ffmpeg API usage).
Shiz
@jwz wrote something, will send patch later
Shiz
@jwz here you go: https://shiz.me/junk/dev/xscreensaver-6.09-ffmpeg-7.1-api/
also contains two optional patches I used to make it build at all on my Fedora setup, since for some reason they put the FFmpeg includes in /usr/include/ffmpeg ¯\_(ツ)_/¯
Peter Krefting
Note to self: To make sure the includes you pass to the configure script are passed to the makefile, put them in INCLUDES, not in CFLAGS.
Looks like I had system-wide ffmpeg headers installed, after all (the LDFLAGS were carried forward, so it *linked* with 7.1.1, it just compiled against older headers).
GNU social JP is a social network, courtesy of GNU social JP管理人. It runs on GNU social, version 2.0.2-dev, available under the GNU Affero General Public License.
All GNU social JP content and data are available under the Creative Commons Attribution 3.0 license.