Conversation

Notices

1. Embed this notice
   Jesse (jaawerth@functional.cafe)'s status on Thursday, 12-Dec-2024 09:53:48 JST Jesse

   • Matthew Lyon

   @mattly @technomancy

   I can make time to look into it some time between now and the end of this weekend unless mattly beats me to it. Unsetting pandoc variables should do it (the man page has a nice Variables for HTML section, btw).

   Failing that, we'd just need to add some specificity to our own color/background-color rules, but better to not have to do that if we can avoid it, since it's easier to tell when pandoc options change between pandoc versions than tracking whether changes to its CSS output break our overrides.

   • Embed this notice
     Jesse (jaawerth@functional.cafe)'s status on Saturday, 14-Dec-2024 02:20:00 JST Jesse

     in reply to

     • Matthew Lyon

     @mattly @technomancy Success! Turns out there's a much simpler fix than we thought. The problem isn't that it's overridden, it's that we're setting background color on the body, but the margin color is coming from a top-level html { ... } rule. So this actually seems to fix it:

     html { background-color: var(--base-bg); }
     

     That said, using pandoc metadata to set the injected styles may still be a good idea just to make it more bulletproof. The only downside to doing so is we'll have to remember that we depend on those CSS vars existing in places other than just fennel.css.

   • Embed this notice
     Jesse (jaawerth@functional.cafe)'s status on Saturday, 14-Dec-2024 02:20:03 JST Jesse

     • Matthew Lyon

     @mattly @technomancy

     We can set document-css to false to turn off all the embedded style, assuming we aren't relying on some parts of it. Otherwise, yeah, setting it to the CSS variables would be the next thing to try.

     Alternatively, we could make our own modified version of pandoc's built-in styles.html, but that is probably overkill if the other approaches work

   • Embed this notice
     Jesse (jaawerth@functional.cafe)'s status on Saturday, 14-Dec-2024 02:25:10 JST Jesse

     in reply to

     • Matthew Lyon

     @mattly @technomancy I can push a patch after working hours that also includes the pandoc variable overrides, but feel free to apply the quick fix in the meantime if you want to correct it ASAP.

     Just to make life easier in the future, browser devtools is clutch for spotting where the rogue styles are coming from. Case in point, here's what I saw in the Computed tab after right-click + inspect on the white margin

   • Embed this notice
     Jesse (jaawerth@functional.cafe)'s status on Saturday, 14-Dec-2024 03:00:27 JST Jesse

     • Matthew Lyon

     @mattly @technomancy In that case, this is the version using the pandoc variables. I think it's better than the manual html { } rule (though we could also include both). I put it in the Makefile instead of markdown-to-website.lua since I figured it'd make it harder to forget we're relying on those CSS vars externally

     diff --git a/Makefile b/Makefile
     index fa92c29..9516711 100644
     --- a/Makefile
     +++ b/Makefile
     @@ -16,6 +16,9 @@ HTML := tutorial.html api.html reference.html lua-primer.html changelog.html \
     
     # This requires pandoc 2.0+
     PANDOC ?= pandoc --syntax-definition fennel-syntax.xml -f gfm \
     + -M fontcolor='var(--base-fg)' \
     + -M backgroundcolor='var(--base-bg)' \
     + -M monobackgroundcolor='var(--source-bg)' \
     -H head.html -A foot.html -T "Fennel" \
     --lua-filter=markdown-to-website.lua
     
   • Embed this notice
     Jesse (jaawerth@functional.cafe)'s status on Saturday, 14-Dec-2024 06:37:22 JST Jesse

     • Matthew Lyon

     @mattly @technomancy I can push them when my workday ends in 30-60 min, but did you want your authorship + whatever commit message to be included?

     I sent mine as just a diff earlier since I didn't care if you rolled it into a larger patch you were working on, but if you want to do a quick git format-patch -1 to send a full commit patch, I can just wait and apply that instead =)