Conversation

Notices

1. Embed this notice
   PuercoPop (puercopop@mastodon.social)'s status on Saturday, 23-Nov-2024 19:26:40 JST PuercoPop

   • Ludovic Courtès

   @civodul And I doubt that I have the most exposure to #nixpkgs and #guix processes. But these are my observations:

   • Embed this notice
     PuercoPop (puercopop@mastodon.social)'s status on Saturday, 23-Nov-2024 19:26:39 JST PuercoPop

     in reply to

     • Ludovic Courtès

     @civodul
     # Merging _your own_ changes requires you to look at other people submissions

     This is a consequence of integration being the responsibility of the CI. #nixpkgs maintainers have to go through the same process as non-maintainers. They can't push to master. If #guix maintainers had to visit https://issues.guix.gnu.org/ my guess is that there would be more eyes on other people submissions.

   • Embed this notice
     Ludovic Courtès (civodul@toot.aquilenet.fr)'s status on Saturday, 23-Nov-2024 19:26:39 JST Ludovic Courtès

     in reply to

     @PuercoPop Guix committers can push to ‘master’, yes, but they don’t have a waiver: their submit for their code for review like everyone else. Their duty as reviewer is also codified:
     https://guix.gnu.org/manual/devel/en/html_node/Commit-Access.html#Helping-Out

     (But it’s fair to say it’s not working well.)

   • Embed this notice
     PuercoPop (puercopop@mastodon.social)'s status on Saturday, 23-Nov-2024 19:26:40 JST PuercoPop

     in reply to

     • Ludovic Courtès

     @civodul
     # Activation Energy of merging

     To merge a change in nixpkgs one needs to press a button. For guix one needs to download the patch locally, rebuild to double check and then push. The extra steps can be done by a CI, it doesn't require a pull request flow.

   • Embed this notice
     PuercoPop (puercopop@mastodon.social)'s status on Saturday, 23-Nov-2024 19:31:29 JST PuercoPop

     in reply to

     • Ludovic Courtès

     @civodul
     # Automated 'first response' triaging of a submission

     This includes adding a reviewer automatically. You don't even have to have a
     commit bit to be able to approve the change. This is important because it lets
     the submitter know that who is they need to reach out in case their change is
     forgotten. It also lets maintainers check their 'backlog' of submissions.

     https://github.com/NixOS/nixpkgs/blob/7eb0c197fbdcedf2e29487b467fc743a1a4e0f0a/maintainers/README.md#how-to-become-a-maintainer

     f/e #guix issues could run guix lint automatically on each submission.

   • Embed this notice
     Ludovic Courtès (civodul@toot.aquilenet.fr)'s status on Saturday, 23-Nov-2024 19:31:29 JST Ludovic Courtès

     in reply to

     @PuercoPop Teams in Guix are an attempt at addressing these very problems (we purposefully chose not to have per-package maintainers back in the day).
     https://guix.gnu.org/manual/devel/en/html_node/Teams.html

     Someone who submits a patch automatically has members of the relevant team(s) Cc’d.

     But again, tooling is not making it as easy as it could, especially for team members.

   • Embed this notice
     PuercoPop (puercopop@mastodon.social)'s status on Sunday, 24-Nov-2024 00:37:05 JST PuercoPop

     in reply to

     • Ludovic Courtès

     @civodul ah, that is true. But one still doesnt have to open issues.guix to submit a patch. So there is less 'foot traffic' from maintainers. That said, I reducing the amount of human work needed to integrate a change is something that would be more impactful. Ie. if one can could tell cuirasa to merge a change to master by sending a message/command/tag

   • Embed this notice
     Ludovic Courtès (civodul@toot.aquilenet.fr)'s status on Sunday, 24-Nov-2024 00:37:05 JST Ludovic Courtès

     in reply to

     @PuercoPop Agreed, though there’s also the fact that every commit must be signed by an authorized committer: this is how users authenticate what ‘guix pull’ gives us and a key security aspect.

     The unfortunate side effect (or not so unfortunate, depending on how one looks at it) is that this rules out automated commits.