Conversation
Notices
-
Embed this notice
[GRLC] (^._.^)ノ :neocat_flag_sapphic: (novenary@akko.wtf)'s status on Tuesday, 29-Oct-2024 05:44:11 JST [GRLC] (^._.^)ノ :neocat_flag_sapphic: pull requests fucking suck
I do not want to review a patch series as a single squashed diff, that is fucking deranged
yet githubs UI makes that absolutely hellish
and the alternative of splitting changes into multiple PRs does not work if there is any sort of dependency in the history-
Embed this notice
small, versatile 6DoF c++ witch *ada (ada@zoner.work)'s status on Tuesday, 29-Oct-2024 05:44:10 JST small, versatile 6DoF c++ witch *ada @novenary@akko.wtf I used to have so many PRs at my former work that was just
"This PR is blocked by [this other PR], please merge that before reviewing this." in a draft state.
I think my record is 6 PRs that depended on one another.Haelwenn /элвэн/ :triskell: likes this. -
Embed this notice
[GRLC] (^._.^)ノ :neocat_flag_sapphic: (novenary@akko.wtf)'s status on Tuesday, 29-Oct-2024 10:06:57 JST [GRLC] (^._.^)ノ :neocat_flag_sapphic: like github is so PR-centric that the entire UX is designed around the assumption that a PR is an indivisible change that will be squashed upon merging (even if creating a merge commit is still the default)
and at the same time it has absolutely no way to link multiple PRs as closely-related changes
now obviously the correct workflow is hidden in there, and it kinda works
you CAN post review comments commit by commit, but some features (such as suggesting changes) simply don't work, and those comments are marked as "outdated"
heck for the longest time, force-pushing a PR was lossy (you lost all previous context)
now it actually logs force-pushes with the old and the new branch heads, but the "compare" button is still completely worthless in case of a rebase...Haelwenn /элвэн/ :triskell: likes this.
-
Embed this notice