Conversation

Notices

1. Embed this notice
    (mint@ryona.agency)'s status on Sunday, 08-Sep-2024 10:30:43 JST 
   Okay, apparently what was causing severe performance issues when loading old-ish long threads, and lately even timeline with notifs, was in fact Neetzshe's patch that preloaded scrobbles into the user profile JSON. This could've probably been solved by an index, but considering the fact I'm lazy and the frontend still loads scrobbles by hammering their separate endpoint, I just added a switch to disable returning them in every status. Having sub-second load times on timeline sure feels refreshing.
   https://gitgud.io/ryonagency/pleroma/-/commit/4507b64267d7d5a767d21c091fe45bd0f42866a1
   • ✙ dcc :pedomustdie: :phear_slackware: likes this.
   • Embed this notice
      (mint@ryona.agency)'s status on Sunday, 08-Sep-2024 10:38:40 JST 

     in reply to

     • Ethical Pedophile
     @BlinkRape That's because of my complicated caching setup to speed things up since I'm hosting an instance in my basement in Russia and proxying it to a VPS in US. Didn't find a workaround to convert those to notice links when requested from a browser yet.
   • Embed this notice
     Ethical Pedophile (blinkrape@posting.lolicon.rocks)'s status on Sunday, 08-Sep-2024 10:38:42 JST Ethical Pedophile

     in reply to
     @mint cool, any idea when I try to load external source on any of your posts it just dumps json to the new browser tab, lol
      likes this.
   • Embed this notice
     Ethical Pedophile (blinkrape@posting.lolicon.rocks)'s status on Sunday, 08-Sep-2024 10:39:38 JST Ethical Pedophile

     in reply to
     @mint not a big deal, I was just curious more than anything
      likes this.
   • Embed this notice
     feld (feld@friedcheese.us)'s status on Sunday, 08-Sep-2024 10:47:27 JST feld

     in reply to
     @mint the current scrobble behavior is insane and needs to go
      likes this.
   • Embed this notice
      (mint@ryona.agency)'s status on Sunday, 08-Sep-2024 10:49:46 JST 

     in reply to

     • feld
     @feld Yeah, I think adding them to user profile is a more sensible approach, it just so happens to cause severe performance issues without some more fiddling.
   • Embed this notice
     feld (feld@friedcheese.us)'s status on Sunday, 08-Sep-2024 10:51:38 JST feld

     in reply to
     @mint Send me a link to a patch / commit that adds them to the account view and I'll see what's up, I took a look at this once before but was confused about some PleromaFE stuff so I shelved it
      likes this.
   • Embed this notice
      (mint@ryona.agency)'s status on Sunday, 08-Sep-2024 10:52:19 JST 

     in reply to

     • feld
     @feld https://git.pleroma.social/pleroma/pleroma/-/merge_requests/3975
     feld likes this.
   • Embed this notice
      (mint@ryona.agency)'s status on Sunday, 08-Sep-2024 10:52:46 JST 

     in reply to

     • feld
     @feld Frontend patch was made before that, so it hammers the old endpoint.
   • Embed this notice
     feld (feld@friedcheese.us)'s status on Sunday, 08-Sep-2024 10:53:33 JST feld

     in reply to
     @mint ok cool so this is the starting point, I'm not home until Monday but yeah this still bothers me a lot and we need to fix it properly
      likes this.
   • Embed this notice
      (mint@ryona.agency)'s status on Sunday, 08-Sep-2024 12:26:28 JST 

     in reply to
     Here we go, opened the longest thread that federated here without timeouts. We're so back.
     Screenshot_20240908_062540.png
     Screenshot_20240908_062548.png
   • Embed this notice
      (mint@ryona.agency)'s status on Sunday, 08-Sep-2024 12:40:17 JST 

     in reply to

     • Pawlicker
     @PurpCat They still work, in fact current frontend implementation never used those fields anyways.
   • Embed this notice
     Pawlicker (purpcat@clubcyberia.co)'s status on Sunday, 08-Sep-2024 12:40:19 JST Pawlicker

     in reply to
     @mint rip scrobbles
   • Embed this notice
      (mint@ryona.agency)'s status on Sunday, 08-Sep-2024 21:07:40 JST 

     in reply to

     • lauralt
     @lauralt No setup, just thought a bit about what thread/timeline/notif pipelines have in common, checked the part that gets the user info, then tried getting scrobbled for a couple of old inactive accounts and came to a realization.
   • Embed this notice
     lauralt (lauralt@ryona.agency)'s status on Sunday, 08-Sep-2024 21:07:41 JST lauralt

     in reply to
     @mint
     
     Very nice, excellent!
     What is a setup that would have caught an issue like this early? Would some post fetching database tests suffice, how about some local end to end tests?