Conversation

Notices

1. Embed this notice
   Jonathan Corbet (corbet@social.kernel.org)'s status on Friday, 06-Sep-2024 15:09:09 JST Jonathan Corbet
   The more I dig through kernel mailing list discussions, the more I think that we would do well to end the use of "NAK" entirely. It is an exercise of power that is hurtful to read and gets in the way of an actual discussion of how a patch needs to be improved. I have, in my maintainer role, never said "NAK" to a patch and plan to continue that way.
   
   *Edited* since people are asking: NAK (or NACK) comes (I believe) from the ASCII negative-acknowledge character. In this context, is an abrupt way for a maintainer to reject a patch.
   • Embed this notice
     Christian Brauner ?? (brauner@mastodon.social)'s status on Friday, 06-Sep-2024 15:09:08 JST Christian Brauner ??

     in reply to

     @corbet Any specific example that triggered this?

   • Embed this notice
     Christian Brauner ?? (brauner@mastodon.social)'s status on Friday, 06-Sep-2024 15:09:08 JST Christian Brauner ??

     in reply to

     @corbet fwiw, I tend to not use it unless the message really isn't getting across.

     Haelwenn /элвэн/ :triskell: likes this.
   • Embed this notice
     Jani Nikula (jani@fosstodon.org)'s status on Friday, 06-Sep-2024 15:09:35 JST Jani Nikula

     in reply to

     • Christian Brauner ??

     @corbet @brauner

     I was going to reply to the original post that we generally try to avoid NAK in the drm subsystem, but then, uh oh.

     I think it's something we strive for, anyway.

   • Embed this notice
     Dave Airlie (airlied@fosstodon.org)'s status on Friday, 06-Sep-2024 15:09:35 JST Dave Airlie

     in reply to

     • Christian Brauner ??
     • Jani Nikula

     @jani @corbet @brauner I've sent mails (perhaps privately, I can't remember), stating any use of NAKs is not productive, and that I would cease pulling stuff from NAK senders unless the next set of patches they submitted were documentation on the area they NAK'ed patches in. We have gotten some documentation as a result.

     Haelwenn /элвэн/ :triskell: likes this.
   • Embed this notice
     Jonathan Corbet (corbet@social.kernel.org)'s status on Friday, 06-Sep-2024 15:09:36 JST Jonathan Corbet

     in reply to

     • Christian Brauner ??
     @brauner I'm digging through the whole Asahi Lina graphics driver story, but it's something I've often thought.
   • Embed this notice
     Vegard Nossum (vegard@mastodon.social)'s status on Friday, 06-Sep-2024 15:10:55 JST Vegard Nossum

     in reply to

     @corbet Proposing NAKs-per-day as a core community health metric

     Haelwenn /элвэн/ :triskell: likes this.