Conversation

Notices

1. Embed this notice
   Talon (talon@dragonscave.space)'s status on Thursday, 29-Aug-2024 20:59:36 JST Talon

   Oh no bitwarden what the hell did you do to your website?
   <a aria-label="go to https://bitwarden.com/products/personal/" data-testid="cta-link" class="plausible-event-name=navigation+drop+menu+click plausible-event-button=products+pm+personal ......

   It keeps going on and on. And the result? A menu that reads like this to a screen reader:

   link go to https://bitwarden.com/pricing/business/
   link go to https://bitwarden.com/download/
   link go to https://bitwarden.com/developers/

   Can we collectively add a thing to VS Code that pops up a really big warning when you control s any file that has aria-label in it that says "You probably don't wanna do this!" and won't let you proceed until you enter a very good reason for why you did this, which is then inspectable in the html source for all of us to see?

   • Embed this notice
     Talon (talon@dragonscave.space)'s status on Thursday, 29-Aug-2024 20:59:42 JST Talon

     in reply to

     • Piggo :verified_horse:

     @piggo it actually used to have one! But really, windows has one, mac has one, linux has one that works with chromium and firefox browsers. So I doubt having a screen reader in Chrome would have made them care enough to try before production.

   • Embed this notice
     Piggo :verified_horse: (piggo@piggo.space)'s status on Thursday, 29-Aug-2024 20:59:44 JST Piggo :verified_horse:

     in reply to
     @talon I think chrome should have some basic screen reader built into the dev tools to make it testable
     GreenSkyOverMe (Monika) repeated this.
   • Embed this notice
     Talon (talon@dragonscave.space)'s status on Thursday, 29-Aug-2024 20:59:57 JST Talon

     in reply to

     • Piggo :verified_horse:

     @piggo on windows you press control windows enter, and on mac you press command f5. On most linux distros you should be able to turn it on with super s, or super alt s. Anything after that is actually using the screen reader itself, which is sadly necessary to test functionality meant for screen readers. Building one into Chrome probably won't help you here as it would need to be similarly complex. Otherwise, the functionality you're testing for would be missing in the screen reader. But in Bitwarden's case, turning on any screen reader, focusing the website and pressing tab a bunch would have caught this problem.

   • Embed this notice
     Piggo :verified_horse: (piggo@piggo.space)'s status on Thursday, 29-Aug-2024 20:59:58 JST Piggo :verified_horse:

     in reply to
     @talon It would lower the barrier a lot, I tried twice to wrap my head around Orca and gave up. I for sure don't have the motivation like someone like you who actually needs it, but it's amazingly obscure
     GreenSkyOverMe (Monika) repeated this.