Conversation
Notices
-
Embed this notice
Good news: buttons and unstyled buttons look great in Themes 3.0 or at least the way they should, also reduced the extraneous CSS that some places did to change icon color of unstyled buttons on hover.
Bad news: themes 3 initialization time is around 1 second, but i'm sure I can optimize it further.
Undetermined news: I'm considering making states essentially "hard-coded" or at least partially. I can't think of many cases where a component might need more than 1 state unless it's an inherently stateful component like Button/Input, all other components so far either have one extra state (text has "faint") or none. It would also help the inheritance between disabled/hover/active/focused.
Oh and also specificity sorting is in place, at least for parents amount.
-
Embed this notice
@vaartis naturally, yes. I still want "compile time" to be as small as possible so that editing themes isn't as pain in the ass.
-
Embed this notice
@hj any chance you could cache it in indexed db or something like that after it builds the CSS?
-
Embed this notice
@vaartis i thought of partial updates but i'm not sure whether it would help, since i would still need to traverse the entire tree anyway. One saving grace is that editor could use "light" version of the tree, i.e. just components themselves without taking the "placement" into account. I do intend on having editor be a "semi-minimalistic", with :marko: FULL POWER :marko: being accessible only through text editing (for which i'll make a proper PISS markup).
Another thing that might be slowing things down right now is that greentext colors are generated essentially everywhere even though it's unnecessary, mostly because there's no "Post" component yet.
-
Embed this notice
@hj hm, could you only partially update them? That should make it much faster for editing. I guess if there's still potential for optimizing the speed of generting the whole thing that's fine too, but reducing the amount of work needed usually helps a lot.
-
Embed this notice
@hj I don't get it at all but good job!
-
Embed this notice
@moth_ball tl;dr: i'm trying to make PleromaFE more consistent and and visually accessible (text clarity) all while keeping ability to change and write custom themes that don't break with new releases. It comes at a performance cost.
Please say "ganbatte", i really need it...
-
Embed this notice
@hj @moth_ball ganbatte
-
Embed this notice
@hj You are such a diligent worker, good boy!
-
Embed this notice
@hj GANBATTE !