Conversation

Notices

1. Embed this notice
   Borked Maikel from :Firehaj: (maikelthedev@blahaj.zone)'s status on Saturday, 03-Jun-2023 01:29:30 JST Borked Maikel from :Firehaj:

   • Kainoa
   • Panos Damelos

   @panos@calckey.social @kainoa@calckey.social Wondering about this. First I do like how they look now, thank you. Partyyy! 🥳🎉
   
   Second. Why is replies always shown when there might be zero replies and yet boosts counter is hidden when there are no boosts?

   • Embed this notice
     Kainoa (kainoa@calckey.social)'s status on Saturday, 03-Jun-2023 01:29:30 JST Kainoa

     in reply to

     • Panos Damelos

     @maikelthedev@blahaj.zone @panos@calckey.social because replies will always be the default view

   • Embed this notice
     Borked Maikel from :Firehaj: (maikelthedev@blahaj.zone)'s status on Saturday, 03-Jun-2023 01:33:39 JST Borked Maikel from :Firehaj:

     in reply to

     • Kainoa
     • Panos Damelos

     @kainoa@calckey.social @panos@calckey.social could we have a "No Replies" when the count is 0 instead of just "Replies" with nothing?
     
     It's a bit confusing to have it there when there are none. By putting a "No" when is zero, you avoid the ambiguity

   • Embed this notice
     Kainoa (kainoa@calckey.social)'s status on Saturday, 03-Jun-2023 01:33:39 JST Kainoa

     in reply to

     • Panos Damelos

     @maikelthedev@blahaj.zone @panos@calckey.social I was going to do that, bit it's going to be a bit harder since Misskey uses a semi-custom i18n system instead of vue-i18n so I can't do easy number replacements with tc()

   • Embed this notice
     Kainoa (kainoa@calckey.social)'s status on Saturday, 03-Jun-2023 01:37:52 JST Kainoa

     in reply to

     • Panos Damelos

     @maikelthedev@blahaj.zone @panos@calckey.social I know, that's what I'm trying to say. But keep in mind that has to be localized, and it's harder to do that without tc

   • Embed this notice
     Borked Maikel from :Firehaj: (maikelthedev@blahaj.zone)'s status on Saturday, 03-Jun-2023 01:37:53 JST Borked Maikel from :Firehaj:

     in reply to

     • Kainoa
     • Panos Damelos

     @kainoa@calckey.social @panos@calckey.social how about the word "Replies" doing the change to something else f pending on the number being 0 or higher than zero.
     
     I mean instead of the number part, the word Replies becoming "No Replies".
     
     That way you don't have to replace any number.

   • Embed this notice
     Kainoa (kainoa@calckey.social)'s status on Saturday, 03-Jun-2023 01:38:35 JST Kainoa

     in reply to

     • Panos Damelos

     @maikelthedev@blahaj.zone @panos@calckey.social https://kazupon.github.io/vue-i18n/guide/pluralization.html

   • Embed this notice
     Kainoa (kainoa@calckey.social)'s status on Saturday, 03-Jun-2023 17:18:43 JST Kainoa

     in reply to

     • Panos Damelos
     • Free

     @panos @maikelthedev@blahaj.zone @freeplay as for why there's "0 replies" instead of "No replies":
     
     RE: https://calckey.social/notes/9ficrw4bem886lo2

   • Embed this notice
     Panos Damelos (panos@calckey.social)'s status on Saturday, 03-Jun-2023 17:18:44 JST Panos Damelos

     in reply to

     • Kainoa
     • Free

     @maikelthedev@blahaj.zone You're right, it's not ideal, my suggestion was to at least not show "Replies" when there are no replies/boosts/reactions etc, so no need for tabs.
     However, when there are boosts but no replies, I think we need an empty/default tab, because if the only tab was Boosts for example, it would be a little confusing, as users expect to see any replies there. As @kainoa@calckey.social said, the default view has always been showing replies under a post, and we should keep it this way. Perhaps it should say "0 Replies" or we could add a "No replies" under the tab, where the replies would normally appear. Let me also bring @freeplay into this, who had the idea for the tabs and implemented it =)

   • Embed this notice
     Panos Damelos (panos@calckey.social)'s status on Saturday, 03-Jun-2023 17:40:41 JST Panos Damelos

     in reply to

     • Kainoa
     • Free

     @kainoa @freeplay it's not "0 Replies" though rn, it's just "Replies". I understood that it's tricky to add "No" instead of a number, but since we already show a number, I guess it could show "0 Replies" instead of "Replies". Not the best solution, but I still think it could be a quick fix for the confusion @maikelthedev@blahaj.zone describes.

     Kainoa likes this.