Conversation

Notices

1. Embed this notice
   feld (feld@bikeshed.party)'s status on Sunday, 05-Feb-2023 12:55:22 JST feld

   in reply to

   • lainy
   • Carl George :fedora: :centos:
   I was always pleased to see @lain choose to merge something functional as-is and refactor it with another MR if some slight adjustments needed to be made
   • Doughnut Lollipop 【記録係】:blobfoxgooglymlem: likes this.
   • Embed this notice
     Carl George :fedora: :centos: (carlwgeorge@fosstodon.org)'s status on Sunday, 05-Feb-2023 12:55:23 JST Carl George :fedora: :centos:

     If someone sends you a pull request, it's rude to close it in favor of your own commit that does the same thing with small adjustments. If changes are needed to the PR in order to merge it, ask for them. The person is literally asking to collaborate with you. Implementing their suggestion without their name attached is stealing credit. It also discourages them from collaborating with you in the future.