Conversation

Notices

1. Embed this notice
   feld (feld@bikeshed.party)'s status on Wednesday, 01-Feb-2023 08:19:17 JST feld

   • Alex Gleason
   @alex is this some weird Mastodon bug you're fixing or is this just drunk coding because this change fixes the "polls show options with thousands of a percent each" bug that I see all the time
   • Embed this notice
     faried nawaz (fn@p.node.pk)'s status on Wednesday, 01-Feb-2023 08:19:16 JST faried nawaz

     in reply to

     • Alex Gleason
     @feld @alex i see that bug in husky.
   • Embed this notice
     feld (feld@bikeshed.party)'s status on Wednesday, 01-Feb-2023 08:26:44 JST feld

     in reply to

     • Alex Gleason
     but you shouldn't be counting the number of people that voted, only the votes
     
     i think that's why this code goes wonky sometimes. the number of votes doesn't always match the number of people maybe due to federation issues, idk
     
     setting pollVotesCount to the number of voters and falling back to number of votes just seems wrong. it should only ever be the number of votes.
   • Embed this notice
     Alex Gleason (alex@gleasonator.com)'s status on Wednesday, 01-Feb-2023 08:26:44 JST Alex Gleason

     in reply to

     • Marcin Mikołajczak

     @feld I think voters_count and votes_count are conditional depending on whether it’s a multi-select poll. @mkljczk