Untitled attachment

Notices where this attachment appears

1. Embed this notice
   Hélène (helene@p.helene.moe)'s status on Wednesday, 17-Aug-2022 02:24:32 JST Hélène

   in reply to

   @trwnh no worries :ablobcatwink:

   I just looked at Mastodon’s code, and it seems that the fragment part of the keyId URI is completely ignored by Mastodon, so… what comes before the fragment is used to find the related Account by uri, however (and considering what we talked about before with GoToSocial… that may be quite a problem, but I don’t know the rest of Mastodon’s codebase, or how Accounts/actors are handled specifically)

   see https://github.com/mastodon/mastodon/blame/main/app/lib/activitypub/tag_manager.rb#L171 which brings relevance to https://github.com/mastodon/mastodon/pull/4630 and https://github.com/mastodon/mastodon/issues/4606 in the discussion

   so, in the end, I’m still not sure how that came to be, and it seems particularly bizarre and unexplained

   @Gargron sorry to cause so much reading! but, do you know where the URI fragment-based key indexing came from? (did you introduce it?) and is there any particular reason for doing it in this manner? nothing seems to define how the keyId parameter is built besides Mastodon, from what I can see, and the support for WebFinger-like URIs in Mastodon for HTTP signatures seem to make that more complex, as well