• Public

  • Public
  • Network
  • Groups
  • Featured
  • Popular
  • People

I hope this message finds you well. I wanted to reach out to you regarding my recent pull request to your repository. I have made several improvements to the code, which I believe would benefit the project as a whole. Firstly, I have included unit tests, added try-catch blocks, and simplified the multimap-by function to enhance the code's reliability and prevent potential errors. I also have added docstrings to make the code more understandable and easier to navigate. Moreover, I have used a threaded ->> macro to simplify the code and replace the println statement with proper logging to improve the code's readability. Finally, I have enhanced the code's modularity and conciseness, making it more maintainable and easier to modify in the future. I believe that these changes would greatly improve the project's overall quality, and I would be honored if you could review my pull request and consider accepting it. Thank you for your time and consideration. ... tonsky Apr 3, 2023 Here you just delay printing warnings, adding extra data structure that’s passed between widths and its call site. That’s one more thing to keep in mind, which makes it harder to follow ... tonsky Apr 3, 2023 Giving name to #{"0" 0 1200} is good. I would’ve move it inside the function with let, though, to keep everything local ... tonsky Apr 3, 2023 I think java will fail and die on trying to open file anyway, giving you adequate enough exception. But the code remains simple ...